Subject: Re: [PATCH] Fix VDSO gettimeofday() when called with NULL struct timeval.

From: [email-masked] (Tony Breeds)
Date: Tue, 26 Jun 2007 09:39:46 +1000

On Mon, Jun 25, 2007 at 03:35:51PM +0200, Segher Boessenkool wrote:

> Yeah.  Not really vital though, no sane program would call
> gettimeofday() with a NULL timeval (since that doesn't do
> anything).  Or did you find such a program (other than a
> testsuite)?

No real program just me testing things.  I wanted to see what the
kernel had in sys_tz ;P
 
> cmplwi r10,0

Will do.  BenH also suggested this change.
 
> No need to renumber the labels.  Either pick a higher
> number for your new label (nothing says they need to be
> in order); or reuse some other number (both your new and
> the original 1: can be 1: without any problem, these are
> local labels after all); or you can use 0: since that's
> a valid local label as well.

Thanks.

Yours Tony

  linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
  Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!