Subject: Re: [PATCH] pcmcia: CompactFlash driver for PA Semi Electra boards

From: [email-masked] (Olof Johansson)
Date: Thu, 5 Jul 2007 09:36:56 -0500

On Wed, Jun 27, 2007 at 06:20:27AM -0500, Milton Miller wrote:

> get_property is now a #define for of_get_property.  I think the use of 
> get_property is being deprecated.

Yeah, it's a pita. I've moved these over now.

> If of_get_property fails to find the property, then you will 
> dereference a NULL pointer in a probe function and will leave the 
> bus_type locked.

Fixed.

> >+       /* XXX No way to undo the io reservation at this time */
> 
> What io reservation is this comment referring to?

ioremap_explicit. I've updated the comment.

> Where is the request_irq undone?

Fixed.

> >+static int __devexit electra_cf_remove(struct of_device *ofdev)
> >+{
> >+       struct device *device = &ofdev->dev;
> >+       struct electra_cf_socket *cf;
> >+
> >+       cf = dev_get_drvdata(device);
> >+
> >+       cf->active = 0;
> >+       pcmcia_unregister_socket(&cf->socket);
> >+       free_irq(cf->irq, cf);
> >+       del_timer_sync(&cf->timer);
> >+
> >+       iounmap(cf->mem_base);
> >+       iounmap(cf->gpio_base);
> >+       release_mem_region(cf->mem_phys, cf->mem_size);
> >+       release_region(cf->io_base, cf->io_size);
> >+
> >
> 
> irq_request?

Huh?

-Olof