From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: leoli@freescale•com, paulus@samba•org
Subject: Re: [PATCH] Add USB support to mpc8349-mitx board port
Date: Sat, 7 Jul 2007 01:48:20 +0200 [thread overview]
Message-ID: <200707070148.20526.arnd@arndb.de> (raw)
In-Reply-To: <20070706222909.19943.39455.stgit@trillian.secretlab.ca>
On Saturday 07 July 2007, Grant Likely wrote:
> --- a/arch/powerpc/platforms/83xx/mpc834x_itx.c
> +++ b/arch/powerpc/platforms/83xx/mpc834x_itx.c
> @@ -63,6 +63,8 @@ static void __init mpc834x_itx_setup_arch(void)
> =A0
> =A0=A0=A0=A0=A0=A0=A0=A0ppc_md.pci_exclude_device =3D mpc83xx_exclude_dev=
ice;
> =A0#endif
> +
> +=A0=A0=A0=A0=A0=A0=A0mpc834x_usb_cfg();
> =A0}
Why is that necessary? Shouldn't there be an of_platform_driver that
simply does all the setup automatically if the device is present?
Arnd <><
next prev parent reply other threads:[~2007-07-06 23:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 22:29 [PATCH] Add USB support to mpc8349-mitx board port Grant Likely
2007-07-06 23:48 ` Arnd Bergmann [this message]
2007-07-07 5:46 ` Grant Likely
2007-07-08 0:34 ` John Rigby
2007-07-08 0:48 ` Grant Likely
2007-07-09 3:55 ` John Rigby
2007-07-09 17:03 ` Grant Likely
2007-07-09 23:35 ` John Rigby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707070148.20526.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=leoli@freescale$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox