Subject: Re: [PATCH 2/2] Add support to OProfile for profiling Cell BE SPUs

From: Arnd Bergmann <[email-masked]>
Date: Fri, 13 Jul 2007 12:02:19 +0200

On Friday 13 July 2007, Bob Nelson wrote:
> We would like this patch included in -mm and 2.6.23.
>=20
> Subject: Add support to OProfile for profiling Cell BE SPUs
>=20
> From: Maynard Johnson <[email-masked]>
>       Bob Nelson <[email-masked]>
>=20

The patch itself looks ok, but unfortunately, you have a few
formal mistakes in the submission. Most importantly, the long
lines got wrapped by your mail client, so it won't apply.

About the start of the mail, please put the 'We would like to...'
part and everything else that is not supposed to show up in
the changelog _below_ the introduction, separated from the
changelog with a single line containing the string '---'.

The Subject: line should not be in the mail body, it's only
used if you want to use the 'quilt mail' tool, which will
move it to the real subject of the mail.

The From: line can only have one name in it. If you want to
give credit to multiple people, that should be in the
changelog text.

Please resend.

	Arnd <><

> This patch updates the existing arch/powerpc/oprofile/op_model_cell.c
> to add in the SPU profiling capabilities. =A0In addition, a 'cell'
> subdirectory
> was added to arch/powerpc/oprofile to hold Cell-specific SPU profiling
> code.
> Also incorporated several fixes from other patches. =A0Check pointer
> returned from kzalloc. =A0Eliminated unnecessary cast. =A0Better error
> handling and cleanup in the related area. =A064-bit unsigned long
> parameter
> was being demoted to 32-bit unsigned int and eventually promoted back to
> unsigned long.
>=20
> Signed-off-by: Carl Love <[email-masked]>
> Signed-off-by: Maynard Johnson <[email-masked]>
> Signed-off-by: Bob Nelson <[email-masked]>
> Acked-by: Arnd Bergmann <[email-masked]>
> Acked-by: Paul Mackerras <[email-masked]>