Subject: Re: [PATCH 27/61] cpm2: Fix whitespace in cpm2_clk_setup().

From: Arnd Bergmann <[email-masked]>
Date: Thu, 19 Jul 2007 02:21:20 +0200

On Wednesday 18 July 2007, Scott Wood wrote:
> Signed-off-by: Scott Wood <[email-masked]>
> ---
>  arch/powerpc/sysdev/cpm2_common.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/cpm2_common.c b/arch/powerpc/sysdev/cpm2_common.c
> index 4e840bd..7e3a983 100644
> --- a/arch/powerpc/sysdev/cpm2_common.c
> +++ b/arch/powerpc/sysdev/cpm2_common.c
> @@ -233,7 +233,7 @@ int cpm2_clk_setup(enum cpm_clk_target target, int clock, int mode)
>         }
>  
>         if (mode == CPM_CLK_RX)
> -               shift +=3;
> +               shift += 3;
>  
>         for (i = 0; i < ARRAY_SIZE(clk_map); i++) {
>                 if (clk_map[i][0] == target && clk_map[i][1] == clock) {

While all your 61 patches look really good to me in general, I think you're driving
the 'one patch per logical change' mantra a little too far. E.g. a number of them
could simply have been consolidated under 'fix obvious coding style violations in
arch/powerpc'.

Having patches that fix a single whitespace bug only causes extra work for both
the author and the reviewer without much benefit.

	Arnd <><