Subject: Re: [PATCH] Update kuroboxH[GD].dts with i2c rtc entries, cleanup

From: David Gibson <[email-masked]>
Date: Mon, 23 Jul 2007 15:30:50 +1000

On Mon, Jul 23, 2007 at 07:28:12AM +0200, Guennadi Liakhovetski wrote:
> On Mon, 23 Jul 2007, David Gibson wrote:
> 
> > On Sun, Jul 22, 2007 at 12:43:11AM +0200, Guennadi Liakhovetski wrote:
> > [snip]
> > > @@ -64,11 +62,19 @@ build with: "dtc -f -I dts -O dtb -o kuroboxHD.dtb -V 16 kuroboxHD.dts"
> > >  			  fef00000 fef00000 00100000>;	/* pci iack */
> > >  
> > >  		i2c@80003000 {
> > > +			#address-cells = <1>;
> > > +			#size-cells = <0>;
> > >  			device_type = "i2c";
> > >  			compatible = "fsl-i2c";
> > >  			reg = <80003000 1000>;
> > >  			interrupts = <5 2>;
> > >  			interrupt-parent = <&mpic>;
> > > +
> > > +			rtc@32 {
> > > +				device_type = "rtc";
> > > +				compatible = "ricoh,rs5c372b";
> > > +				reg = <32>;
> > 
> > Ok, just making sure that rtc at 0x32 (decimal 50) is correct, rather
> > than at decimal 32.
> 
> Yes, it is. I even tested it:-)

Ok, just making sure, since it's an easy mistake to make.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson