Subject: Re: [PATCH 3/5 v3] Add the platform device support with RapidIO to MPC8641HPCN platform.

From: Arnd Bergmann <[email-masked]>
Date: Sun, 29 Jul 2007 15:56:35 +0200

On Thursday 26 July 2007, Zhang Wei wrote:
> +
> +static struct of_device_id mpc86xx_of_ids[] =3D {
> +=A0=A0=A0=A0=A0=A0=A0{ .type =3D "soc", },
> +=A0=A0=A0=A0=A0=A0=A0{ .compatible =3D "fsl,rapidio-delta", },
> +=A0=A0=A0=A0=A0=A0=A0{},
> +};

With the device tree source you have posted in 2/5, the rapidio node is
a child of the soc bus, and it doesn't have any children of its own.
Therefore it is completely equivalent to _only_ add the soc type
to mpc86xx_of_ids[], as in=20

static struct of_device_id mpc86xx_of_ids[] =3D {
       { .type =3D "soc", },
       {},
};

Even if you intend to add children to the rapidio node in the future,
I'd think it would be more appropriate to have those scanned by
the rapidio bus driver, not by of_platform.

	Arnd <><