From: Domen Puncer <domen.puncer@telargo•com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: [PATCH] lite5200b: flash definition in dts
Date: Thu, 2 Aug 2007 07:58:30 +0200 [thread overview]
Message-ID: <20070802055830.GM4529@moe.telargo.com> (raw)
In-Reply-To: <fa686aa40708010541n4d4900cfv7042d6ca685416d1@mail.gmail.com>
On 01/08/07 06:41 -0600, Grant Likely wrote:
> On 8/1/07, Domen Puncer <domen.puncer@telargo•com> wrote:
> > Add flash definition for to lite5200b dts, and while at it
> > fix "ranges" for soc node.
> >
...
> > +++ work-powerpc.git/arch/powerpc/boot/dts/lite5200b.dts
> > @@ -52,7 +52,8 @@
> > revision = ""; // from bootloader
> > #interrupt-cells = <3>;
> > device_type = "soc";
> > - ranges = <0 f0000000 f0010000>;
> > + ranges = <00000000 f0000000 00010000
> > + fe000000 fe000000 02000000>;
>
> I don't think this is the right approach. I think the SoC node is
> intended for describing the on-chip devices, and the ranges property
> reflects that. Shouldn't flash nodes be up 1 level?
>
That would make sense, however, it does not work, probably because:
arch/powerpc/kernel/of_platform.c:
32 /*
33 * The list of OF IDs below is used for matching bus types in the
34 * system whose devices are to be exposed as of_platform_devices.
35 *
36 * This is the default list valid for most platforms. This file provides
37 * functions who can take an explicit list if necessary though
38 *
39 * The search is always performed recursively looking for children of
40 * the provided device_node and recursively if such a children matches
41 * a bus type in the list
42 */
43
44 static struct of_device_id of_default_bus_ids[] = {
45 { .type = "soc", },
46 { .compatible = "soc", },
47 { .type = "spider", },
48 { .type = "axon", },
49 { .type = "plb5", },
50 { .type = "plb4", },
51 { .type = "opb", },
52 { .type = "ebc", },
53 {},
54 };
Suggestions?
BTW. phy's are also not on chip, but are usualy listed under "soc"
(ie. mpc885ads.dts). Or rtc chip connected to i2c in kuroboxHD.dts.
Domen
next prev parent reply other threads:[~2007-08-02 5:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-19 9:54 [PATCH] lite5200b: flash definition in dts Domen Puncer
2007-08-01 6:52 ` Domen Puncer
2007-08-01 12:41 ` Grant Likely
2007-08-02 5:58 ` Domen Puncer [this message]
2007-08-02 6:23 ` Grant Likely
2007-08-02 16:56 ` Scott Wood
2007-08-07 7:02 ` [PATCH v2] " Domen Puncer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070802055830.GM4529@moe.telargo.com \
--to=domen.puncer@telargo$(echo .)com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox