From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx•de>,
linux-serial@vger•kernel.org
Subject: Re: 8250.c::autoconfig() fails loopback test on MPC824[15]
Date: Sun, 5 Aug 2007 01:35:07 +0200 [thread overview]
Message-ID: <200708050135.07753.arnd@arndb.de> (raw)
In-Reply-To: <Pine.LNX.4.60.0708050106270.4299@poirot.grange>
On Sunday 05 August 2007, Guennadi Liakhovetski wrote:
> I tried using of_serial.c on a (PPC) MPC8241 based system, which has a
> "16650A" compatible double UART built into the SoC. Using of_serial.c
> causes the ports to be autoconfigured, and this fails. The loopback test
> fails, because the MSR register on 824[15] doesn't implement the
> UART_MSR_DCD bit. Question: what's better, teach 8250.c to handle UARTs
> without this bit, or set the UPF_SKIP_TEST bit in of_serial.c for these
> SOCs to skip the loopback test altogether? The latter is certainly easier
> and affects much fewer systems, so, I'd go for that.
Yes, that sounds good. Just make sure you test the "compatible" property
in the device node for something appropriate. In of_platform_serial_probe(),
you can then do something like
if (of_device_is_compatible(ofdev, "mpc8241-serial"))
flags |= UPF_SKIP_TEST;
Arnd <><
next prev parent reply other threads:[~2007-08-04 23:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 23:17 8250.c::autoconfig() fails loopback test on MPC824[15] Guennadi Liakhovetski
2007-08-04 23:35 ` Arnd Bergmann [this message]
2007-08-05 14:06 ` Guennadi Liakhovetski
2007-08-05 16:41 ` Arnd Bergmann
2007-08-05 21:31 ` Jon Loeliger
2007-08-05 21:39 ` Guennadi Liakhovetski
2007-08-05 21:50 ` Jon Loeliger
2007-08-05 21:57 ` Arnd Bergmann
2007-08-06 19:29 ` Segher Boessenkool
2007-08-06 19:54 ` Guennadi Liakhovetski
2007-08-06 19:15 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708050135.07753.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=g.liakhovetski@gmx$(echo .)de \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox