Subject: Re: [spi-devel-general] [PATCH] [SPI][POWERPC] spi_mpc83xx: fix prescale modulus calculation

From: David Brownell <[email-masked]>
Date: Mon, 6 Aug 2007 08:44:40 -0700

On Monday 06 August 2007, Anton Vorontsov wrote:
> +
> +                       if (pm)
> +                               pm--;
> +                       else /* this floods dmesg if using mmc_spi, so dbg */
> +                               dev_dbg(&spi->dev, "Requested speed is too "
> +                                       "high: %d Hz. Will use %d Hz instead.\n",
> +                                       spi->max_speed_hz, mpc83xx_spi->spibrg / 4);

Except that's not worthy of any message whatsoever, so it shouldn't
even be a debug message:  user says "give me at most X", driver says
"fine", end of story.

I'm more bothered by the earlier message, which gives a rate higher
than X instead of cleanly failing.

- Dave