From: tony@bakeyournoodle•com (Tony Breeds)
To: LinuxPPC-dev <linuxppc-dev@ozlabs•org>,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: Device tree aware EMAC driver
Date: Wed, 8 Aug 2007 13:16:43 +1000 [thread overview]
Message-ID: <20070808031643.GK10345@bakeyournoodle.com> (raw)
In-Reply-To: <20070807062231.GB8351@localhost.localdomain>
On Tue, Aug 07, 2007 at 04:22:31PM +1000, David Gibson wrote:
> Based on BenH's earlier work, this is a new version of the EMAC driver
> for the built-in ethernet found on PowerPC 4xx embedded CPUs. The
> same ASIC is also found in the Axon bridge chip. This new version is
> designed to work in the arch/powerpc tree, using the device tree to
> probe the device, rather than the old and ugly arch/ppc OCP layer.
<snip>
Hi David,
I had a look over the patch FWIW, asside from the points below
looks good.
Minor nits:
* Shouldn't ndev->priv accesses, use netdev_priv() ? if not a comment
somewhere about why not will keep the janators off your back.
* c++ style comments
* in emac_probe():
+ /* Wait for dependent devices */
+ err = -ENODEV;
+ err = emac_wait_deps(dev);
The initialisation to -ENODEV is pointless right?
* s/get_property/of_get_property/g or you'll make sfr grumpy ;P
* In drivers/net/ibm_newemac/Makefile, I think the preferred method is
to use ibm_newemac-y rather than ibm_newemac-objs.
Is there any reason to leave config IBM_NEW_EMAC (and IBM_EMAC) in
drivers/net/Kconfig ? It seems to me they'd be nicer to in the
appropriate drivers/net/*Kconfig.
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
next prev parent reply other threads:[~2007-08-08 3:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 6:22 Device tree aware EMAC driver David Gibson
2007-08-07 12:15 ` Josh Boyer
2007-08-08 1:18 ` David Gibson
2007-08-08 3:16 ` Tony Breeds [this message]
2007-08-08 5:09 ` David Gibson
2007-08-08 7:34 ` Benjamin Herrenschmidt
2007-08-08 7:33 ` Benjamin Herrenschmidt
2007-08-10 20:39 ` Segher Boessenkool
2007-08-13 1:05 ` David Gibson
2007-08-11 3:51 ` Olof Johansson
[not found] <20070823035601.GL7042@localhost.localdomain>
2007-08-23 7:30 ` Benjamin Herrenschmidt
2007-09-14 22:37 ` Josh Boyer
-- strict thread matches above, loose matches on Subject: below --
2007-05-30 6:17 David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070808031643.GK10345@bakeyournoodle.com \
--to=tony@bakeyournoodle$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox