public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need
Date: Fri, 17 Aug 2007 19:42:25 +0200	[thread overview]
Message-ID: <200708171942.25914.arnd@arndb.de> (raw)
In-Reply-To: <200708171905.52855.arnd@arndb.de>

On Friday 17 August 2007, Arnd Bergmann wrote:
> The m8260_pci.h file is not namespace clean, it defines macros like
> PCI_CFG_ADDR_REG that are likely to create conflicts at some point of
> time. Since the only file including this header is 
> arch/powerpc/platforms/82xx/m82xx_pci.h, I'd suggest merging the two,
> to make sure nobody can accidentally include it.

Upon closer inspection, none of the definitions in this file are
actually used in arch/powerpc, or should be.

So, can we just kill that file, as you did with the others in your
first patch?

	Arnd <><

  reply	other threads:[~2007-08-17 20:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-17  7:11 [PATCH 0/3] Remove need for include/asm-ppc Kumar Gala
2007-08-17  7:12 ` [PATCH 1/3] [POWERPC] Remove old includes from arch/ppc Kumar Gala
2007-08-17  7:14   ` [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need Kumar Gala
2007-08-17  7:15     ` [PATCH 3/3] [POWERPC] Stop include asm-ppc when building ARCH=powerpc for ppc32 Kumar Gala
2007-08-17  8:13       ` Stephen Rothwell
2007-08-17 12:55         ` Kumar Gala
2007-08-17 17:05     ` [PATCH 2/3] [POWERPC] Copy over headers from arch/ppc to arch/powerpc that we need Arnd Bergmann
2007-08-17 17:42       ` Arnd Bergmann [this message]
2007-08-17 20:45       ` Scott Wood
2007-08-17 20:50         ` Scott Wood
2007-08-17 23:25     ` Segher Boessenkool
2007-08-18  5:40       ` Kumar Gala
2007-08-17 12:30 ` [PATCH 0/3] Remove need for include/asm-ppc Josh Boyer
2007-08-17 12:56   ` Kumar Gala
2007-08-17 17:06 ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708171942.25914.arnd@arndb.de \
    --to=arnd@arndb$(echo .)de \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox