Subject: Re: [PATCH 10/20] bootwrapper: Add CPM serial driver.

From: David Gibson <[email-masked]>
Date: Tue, 21 Aug 2007 12:42:00 +1000

On Mon, Aug 20, 2007 at 12:39:57PM -0500, Scott Wood wrote:
> This serial port is used on all 8xx, many 82xx, and some 85xx chips.
> 
> The driver requires that the port has already been set up by the firmware
> and/or platform code.
> 
> Signed-off-by: Scott Wood <[email-masked]>

Acked-by: David Gibson <[email-masked]>

[snip]
> diff --git a/arch/powerpc/boot/serial.c b/arch/powerpc/boot/serial.c
> index 944f0ee..d47f8e0 100644
> --- a/arch/powerpc/boot/serial.c
> +++ b/arch/powerpc/boot/serial.c
> @@ -121,6 +121,11 @@ int serial_console_init(void)
>  		rc = ns16550_console_init(devp, &serial_cd);
>  	else if (dt_is_compatible(devp, "marvell,mpsc"))
>  		rc = mpsc_console_init(devp, &serial_cd);
> +	else if (dt_is_compatible(devp, "fsl,cpm1-scc-uart") ||
> +	         dt_is_compatible(devp, "fsl,cpm1-smc-uart") ||
> +	         dt_is_compatible(devp, "fsl,cpm2-scc-uart") ||
> +	         dt_is_compatible(devp, "fsl,cpm2-smc-uart"))
> +		rc = cpm_console_init(devp, &serial_cd);

If all these variants admit a compatible driver, there really should
be defined a compatible value that they all include in the device
tree.   But I guess you'd still need all these tests for device trees
which didn't have it.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson