From: Brad Boyer <flar@allandria•com>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: "linuxppc-dev@ozlabs•org list" <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>,
David Gibson <david@gibson•dropbear.id.au>
Subject: Re: asm-ppc header issues when building ARCH=powerpc
Date: Thu, 23 Aug 2007 11:56:32 -0700 [thread overview]
Message-ID: <20070823185632.GA3571@cynthia.pants.nu> (raw)
In-Reply-To: <F19C9986-9E53-47F3-835D-C93DA9C3ADED@kernel.crashing.org>
On Wed, Aug 22, 2007 at 11:16:03PM -0500, Kumar Gala wrote:
> On Aug 22, 2007, at 10:33 PM, David Gibson wrote:
> >> My analysis of <asm/bootinfo.h> usage:
> >>
> >> ./drivers/macintosh/adb-iop.c:#include <asm/bootinfo.h> remove
> >> ./drivers/char/vme_scc.c:#include <asm/bootinfo.h> 68k only
> >> ./drivers/char/serial167.c:#include <asm/bootinfo.h> 68k only
> >> ./drivers/serial/dz.c:#include <asm/bootinfo.h> decstation
> >> ./drivers/mtd/devices/ms02-nv.c:#include <asm/bootinfo.h> decstation
> >> ./drivers/net/macsonic.c:#include <asm/bootinfo.h> 68k
> >> ./drivers/net/jazzsonic.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/pmag-aa-fb.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/maxinefb.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/logo/logo.c:#include <asm/bootinfo.h> mips
> >> ./drivers/video/macfb.c:#include <asm/bootinfo.h> 68k
> >> ./drivers/video/valkyriefb.c:#include <asm/bootinfo.h> 68k
> >
> > Uh.. I'm pretty sure valkyriefb.c is for (old) PowerMacs, not 68k.
>
> It appears to be both. If you look at the include its protected by a
> #ifdef CONFIG_MAC which we is only defined on m68k.
According to drivers/video/macfb.c, both the Quadra 630 and Performa 588
have the Valkyrie chip for their video. I don't remember which ppc based
models have it, but it's definitely on both architectures.
Just as an extra note, the file drivers/macintosh/adb-iop.c is m68k only,
so you should probably leave that alone as well. It probably doesn't need
that header, but the change should really come from the 68k side of things.
Brad Boyer
flar@allandria•com
next prev parent reply other threads:[~2007-08-23 18:56 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-22 15:19 asm-ppc header issues when building ARCH=powerpc Kumar Gala
2007-08-22 16:01 ` Scott Wood
2007-08-22 19:30 ` Josh Boyer
2007-08-23 2:49 ` David Gibson
2007-08-23 3:09 ` Kumar Gala
2007-08-23 2:47 ` David Gibson
2007-08-23 3:22 ` Kumar Gala
2007-08-23 17:33 ` Scott Wood
2007-08-23 18:00 ` Kumar Gala
2007-08-23 3:33 ` Kumar Gala
2007-08-23 3:33 ` David Gibson
2007-08-23 4:16 ` Kumar Gala
2007-08-23 9:47 ` Geert Uytterhoeven
2007-08-23 18:56 ` Brad Boyer [this message]
2007-08-24 7:10 ` Geert Uytterhoeven
2007-08-24 7:24 ` Kumar Gala
2007-08-24 7:24 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823185632.GA3571@cynthia.pants.nu \
--to=flar@allandria$(echo .)com \
--cc=david@gibson$(echo .)dropbear.id.au \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox