From: Arnd Bergmann <arnd@arndb•de>
To: Geoff Levand <geoffrey.levand@am•sony.com>
Cc: "Noguchi, Masato" <Masato.Noguchi@jp•sony.com>,
"linuxppc-dev@ozlabs•org" <linuxppc-dev@ozlabs•org>,
Paul Mackerras <paulus@samba•org>, Jeremy Kerr <jk@ozlabs•org>
Subject: Re: [patch 1/2] PS3: Clear SPU Class 0 interrupts in handler
Date: Wed, 5 Sep 2007 00:50:30 +0200 [thread overview]
Message-ID: <200709050050.30968.arnd@arndb.de> (raw)
In-Reply-To: <46DD4777.8050402@am.sony.com>
On Tuesday 04 September 2007, Geoff Levand wrote:
> From: Masato Noguchi <Masato.Noguchi@jp•sony.com>
>=20
> Fix a bug that causes the PS3 to hang on the SPU Class 0 interrupt.
>=20
> The Cell BE Architecture spec states that the SPU MFC Class 0 interrupt
> is delivered as a pulse. =C2=A0The current spu interrupt handler assumes =
this
> behavior and does not clear the interrupt status.
>=20
> The PS3 hypervisor visualizes all SPU interrupts as level, and on return
> from the interrupt handler the hypervisor will deliver a new virtual
> interrupt for any unmasked interrupts which for which the status has not
> been cleared. =C2=A0This fix clears the interrupt status in the interrupt
> handler.
Right, we have this one in the sdk3.0/2.6.22-arnd2 kernel since I pulled
in all of the ps3-linux tree, so it was already part of our testing,
and the explanation makes sense, so we should certainly have it
upstream.
Jeremy, please add this to your patch queue.
> Signed-off-by: Masato Noguchi <Masato.Noguchi@jp•sony.com>
> Signed-off-by: Geoff Levand <geoffrey.levand@am•sony.com>
Acked-by: Arnd Bergmann <arnd.bergmann@de•ibm.com>
prev parent reply other threads:[~2007-09-04 22:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 11:54 [patch 1/2] PS3: Clear SPU Class 0 interrupts in handler Geoff Levand
2007-09-04 22:50 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709050050.30968.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=Masato.Noguchi@jp$(echo .)sony.com \
--cc=geoffrey.levand@am$(echo .)sony.com \
--cc=jk@ozlabs$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox