Subject: Re: [patch 5/6] Walnut board support

From: David Gibson <[email-masked]>
Date: Wed, 5 Sep 2007 11:09:45 +1000

On Tue, Sep 04, 2007 at 07:37:41AM -0500, Josh Boyer wrote:
> On Sun, 02 Sep 2007 08:59:06 -0500
> Josh Boyer <[email-masked]> wrote:
> 
> > On Mon, 2007-09-03 at 11:11 +1000, David Gibson wrote:
> > > On Fri, Aug 31, 2007 at 03:04:54PM -0500, Josh Boyer wrote:
> > > > Board support for the PPC405 Walnut evaluation board
> > > > 
> > > > Signed-off-by: Josh Boyer <[email-masked]>
> > > 
> > > [snip]
> > > > --- linux-2.6.orig/arch/powerpc/platforms/40x/Kconfig
> > > > +++ linux-2.6/arch/powerpc/platforms/40x/Kconfig
> > > > @@ -53,13 +53,13 @@
> > > >  #	help
> > > >  #	  This option enables support for the IBM PPC405GPr evaluation board.
> > > >  
> > > > -#config WALNUT
> > > > -#	bool "Walnut"
> > > > -#	depends on 40x
> > > > -#	default y
> > > > -#	select 405GP
> > > > -#	help
> > > > -#	  This option enables support for the IBM PPC405GP evaluation board.
> > > > +config WALNUT
> > > > +	bool "Walnut"
> > > > +	depends on 40x
> > > > +	default y
> > > > +	select 405GP
> > > > +	help
> > > > +	  This option enables support for the IBM PPC405GP evaluation board.
> > > 
> > > Surely this needs WANT_DEVICE_TREE, too.
> > 
> > Yes, will be fixed.
> 
> Er, actually no it won't.  It doesn't need to be selected here, as 40x
> in arch/powerpc/platforms/Kconfig.cputype already selects
> WANT_DEVICE_TREE.  Same thing that ebony and bamboo do for 44x.

Oh, yes, so it does, sorry.  Though we may need to change that if
anyone goes and puts a real OF implementation on some 44x board.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson