From: Randy Dunlap <randy.dunlap@oracle•com>
To: Zhang Wei <wei.zhang@freescale•com>
Cc: shannon.nelson@intel•com, linux-kernel@vger•kernel.org,
linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.
Date: Fri, 7 Sep 2007 08:58:45 -0700 [thread overview]
Message-ID: <20070907085845.54dc88f8.randy.dunlap@oracle.com> (raw)
In-Reply-To: <11891624582950-git-send-email-wei.zhang@freescale.com>
On Fri, 7 Sep 2007 18:54:18 +0800 Zhang Wei wrote:
> Signed-off-by: Zhang Wei <wei.zhang@freescale•com>
> Signed-off-by: Ebony Zhu <ebony.zhu@freescale•com>
> ---
> drivers/dma/Kconfig | 8 +
> drivers/dma/Makefile | 1 +
> drivers/dma/fsldma.c | 995 ++++++++++++++++++++++++++++++++++++++++++++++++++
> drivers/dma/fsldma.h | 188 ++++++++++
> 4 files changed, 1192 insertions(+), 0 deletions(-)
> create mode 100644 drivers/dma/fsldma.c
> create mode 100644 drivers/dma/fsldma.h
>
> --- /dev/null
> +++ b/drivers/dma/fsldma.c
> @@ -0,0 +1,995 @@
Thanks for using kernel-doc notation. However, ...
> +/**
> + * fsl_dma_alloc_descriptor - Allocate descriptor from channel's DMA pool.
Function parameters need to be listed & described here.
See Documentation/kernel-doc-nano-HOWTO.txt or other source files
for examples.
(Applies to all documented function interfaces here.)
> + *
> + * Return - The descriptor allocated. NULL for failed.
> + */
> +static struct fsl_desc_sw *fsl_dma_alloc_descriptor(
> + struct fsl_dma_chan *fsl_chan,
> + gfp_t flags)
> +{
...
> +}
> +/**
> + * fsl_chan_xfer_ld_queue -- Transfer the link descriptors in channel
> + * ld_queue.
The function's "short description" (unfortunately) must be on only one
line. E.g.:
* fsl_chan_xfer_ld_queue - Transfer link descriptors in channel ld_queue.
> + */
> +static void fsl_chan_xfer_ld_queue(struct fsl_dma_chan *fsl_chan)
> +{
...
> +}
> diff --git a/drivers/dma/fsldma.h b/drivers/dma/fsldma.h
> new file mode 100644
> index 0000000..05be9ed
> --- /dev/null
> +++ b/drivers/dma/fsldma.h
> @@ -0,0 +1,188 @@
> +struct fsl_dma_chan_regs {
> + __mix32 mr; /* 0x00 - Mode Register */
> + __mix32 sr; /* 0x04 - Status Register */
> + __mix64 cdar; /* 0x08 - Cureent descriptor address register */
Current
> + __mix64 sar; /* 0x10 - Source Address Register */
> + __mix64 dar; /* 0x18 - Destination Address Register */
> + __mix32 bcr; /* 0x20 - Byte Count Register */
> + __mix64 ndar; /* 0x24 - Next Descriptor Address Register */
> +};
---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
next prev parent reply other threads:[~2007-09-07 15:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 10:54 [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors Zhang Wei
2007-09-07 15:58 ` Randy Dunlap [this message]
2007-09-11 10:06 ` Zhang Wei-r63237
2007-09-11 14:20 ` Randy Dunlap
2007-09-07 16:00 ` Nelson, Shannon
2007-09-11 10:10 ` Zhang Wei-r63237
2007-09-11 14:20 ` Scott Wood
2007-09-11 15:15 ` Nelson, Shannon
2007-09-09 17:53 ` Dan Williams
2007-09-09 21:48 ` Timur Tabi
2007-09-09 22:10 ` Dan Williams
2007-09-11 10:30 ` Zhang Wei-r63237
2007-09-13 17:17 ` Dan Williams
[not found] ` <20070907223553.GA18599@freescale.com>
2007-09-13 10:13 ` [PATCH 5/5] Add DMA engine driver for Freescale MPC85xxprocessors Zhang Wei-r63237
2007-09-13 14:49 ` Scott Wood
2007-09-13 16:25 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070907085845.54dc88f8.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=shannon.nelson@intel$(echo .)com \
--cc=wei.zhang@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox