From: Olof Johansson <olof@lixom•net>
To: Milton Miller <miltonm@bga•com>
Cc: ppcdev <linuxppc-dev@ozlabs•org>
Subject: Re: [PATCH] powerpc: Add workaround for MPICs with broken register reads
Date: Fri, 7 Sep 2007 04:16:37 -0500 [thread overview]
Message-ID: <20070907091637.GA32102@lixom.net> (raw)
In-Reply-To: <d62ce2299f9d423f95cd8ee50b3b7cff@bga.com>
On Thu, Sep 06, 2007 at 09:55:21AM -0500, Milton Miller wrote:
> On Wed Sep 5 12:44:17 EST 2007, Olof Johansson wrote:
>> diff --git a/arch/powerpc/platforms/Kconfig
>> b/arch/powerpc/platforms/Kconfig
>> index 041df77..b9f1efa 100644
>> --- a/arch/powerpc/platforms/Kconfig
>> +++ b/arch/powerpc/platforms/Kconfig
>> @@ -137,6 +137,10 @@ config MPIC_U3_HT_IRQS
>> depends on PPC_MAPLE
>> default y
>>
>> +config MPIC_BROKEN_REGREAD
>> + bool
>> + depends on PPC_PASEMI
>> +
>> config IBMVIO
>> depends on PPC_PSERIES || PPC_ISERIES
>> bool
>> diff --git a/arch/powerpc/platforms/pasemi/Kconfig
>> b/arch/powerpc/platforms/pasemi/Kconfig
>> index 95cd90f..117d90a 100644
>> --- a/arch/powerpc/platforms/pasemi/Kconfig
>> +++ b/arch/powerpc/platforms/pasemi/Kconfig
>> @@ -5,6 +5,7 @@ config PPC_PASEMI
>> select MPIC
>> select PPC_UDBG_16550
>> select PPC_NATIVE
>> + select MPIC_BROKEN_REGREAD
>> help
>> This option enables support for PA Semi's PWRficient line
>> of SoC processors, including PA6T-1682M
>
>
> Since you are using select (and not default y), instead of the depends on
> PPC_PASEMI how about adding a short description of what the config does as
> help text, in case some future mpic has a similar bug?
Thanks Milton, that's a reasonable suggestion (not that any of the other
options do it, including the very vague MPIC_WEIRD :-).
New patch posted shortly.
-Olof
next prev parent reply other threads:[~2007-09-07 9:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 2:44 [PATCH] powerpc: Add workaround for MPICs with broken register reads Olof Johansson
2007-09-06 14:55 ` Milton Miller
2007-09-07 9:16 ` Olof Johansson [this message]
2007-09-07 9:21 ` [PATCH v2] " Olof Johansson
2007-09-07 14:11 ` Milton Miller
2007-09-07 19:12 ` Olof Johansson
2007-09-07 19:13 ` [PATCH v3] " Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070907091637.GA32102@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=miltonm@bga$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox