From: Olof Johansson <olof@lixom•net>
To: Johannes Berg <johannes@sipsolutions•net>
Cc: linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>
Subject: Re: [RFC/PATCH 2/2] Generic clockevents and no-idle-HZ for PowerPC
Date: Fri, 7 Sep 2007 14:16:16 -0500 [thread overview]
Message-ID: <20070907191616.GB6765@lixom.net> (raw)
In-Reply-To: <1189173891.28781.162.camel@johannes.berg>
On Fri, Sep 07, 2007 at 04:04:51PM +0200, Johannes Berg wrote:
> On Fri, 2007-09-07 at 00:44 +1000, Paul Mackerras wrote:
> > This creates a clockevent for the PowerPC decrementer and registers it
> > with the generic clock/timer system, and implements the dynamic ticks
> > (no idle HZ) option for PowerPC.
>
> I tried both patches applied and with/without CONFIG_NOHZ but my quad G5
> won't boot. Anybody else have more luck?
Did you try with the two changes I suggested? Patch below.
diff --git a/arch/powerpc/kernel/time.c b/arch/powerpc/kernel/time.c
index 1353d73..c863b07 100644
--- a/arch/powerpc/kernel/time.c
+++ b/arch/powerpc/kernel/time.c
@@ -554,6 +554,7 @@ void timer_interrupt(struct pt_regs * regs)
u64 tb_next_jiffy;
struct clock_event_device *evt = &per_cpu(decrementers, cpu);
+ set_dec(DECREMENTER_MAX);
#ifdef CONFIG_PPC32
if (atomic_read(&ppc_n_lost_interrupts) != 0)
do_IRQ(regs);
@@ -931,8 +932,6 @@ void __init time_init(void)
/* Register the clocksource */
clocksource_init();
-
- set_dec(DECREMENTER_MAX);
}
next prev parent reply other threads:[~2007-09-07 19:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-06 14:44 [RFC/PATCH 2/2] Generic clockevents and no-idle-HZ for PowerPC Paul Mackerras
2007-09-06 19:15 ` Olof Johansson
2007-09-06 20:03 ` Olof Johansson
2007-09-07 14:04 ` Johannes Berg
2007-09-07 19:16 ` Olof Johansson [this message]
2007-09-07 19:26 ` Johannes Berg
2007-09-07 20:59 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070907191616.GB6765@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=johannes@sipsolutions$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox