Subject: Re: Document and implement an improved flash device binding for powerpc (v5)

From: David Gibson <[email-masked]>
Date: Mon, 10 Sep 2007 13:00:30 +1000

On Fri, Sep 07, 2007 at 04:25:10PM +0200, Segher Boessenkool wrote:
> > This patch replaces the binding for flash chips in
> > booting-without-of.txt with an clarified and improved version.  It
> > also makes drivers/mtd/maps/physmap_of.c recognize this new binding.
> > Finally it revises the Ebony device tree source to use the new binding
> > as an example.
> >
> > Signed-off-by: David Gibson <[email-masked]>
> 
> Acked-by: Segher Boessenkool <[email-masked]>
> 
> Thanks for doing this work David!
> 
> 
> > +	/* First look for RedBoot table or partitions on the command
> > +	 * line, these take precedence over device tree information */
> 
> Any specific reason you chose this order?  Just curious...

Well, RedBoot on the grounds that an on-device partition table, if
present, should take precedence over platform defaults.  And that
overriding partition information on the command line should, well,
override...

> > +		.data		= (void *)"jedec_probe",
> 
> Hrm, this cast is only getting rid of the const-ness of the
> string literal -- maybe .data should be declared const, or
> does the majority of users want it writable?

Not sure.  But this is defined in the core anyway, and I didn't really
want to bother with delving into that at this time.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson