public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: tony@bakeyournoodle•com (Tony Breeds)
To: Linux Kernel ML <linux-kernel@vger•kernel.org>,
	LinuxPPC-dev <linuxppc-dev@ozlabs•org>
Cc: zach@vmware•com, John Stultz <johnstul@us•ibm.com>,
	Paul Mackerras <paulus@samba•org>,
	Andrew Morton <akpm@linux-foundation•org>,
	Thomas Gleixner <tglx@linutronix•de>
Subject: Fix "no_sync_cmos_clock"  logic inversion in kernel/time/ntp.c
Date: Tue, 11 Sep 2007 17:46:08 +1000	[thread overview]
Message-ID: <20070911074608.GD9814@bakeyournoodle.com> (raw)


Signed-off-by: Tony Breeds <tony@bakeyournoodle•com>

---

Seems to me that this timer will only get started on platforms that say
they don't want it?

 kernel/time/ntp.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: working/kernel/time/ntp.c
===================================================================
--- working.orig/kernel/time/ntp.c	2007-09-11 17:34:44.000000000 +1000
+++ working/kernel/time/ntp.c	2007-09-11 17:34:55.000000000 +1000
@@ -226,7 +226,7 @@ static void sync_cmos_clock(unsigned lon
 
 static void notify_cmos_timer(void)
 {
-	if (no_sync_cmos_clock)
+	if (!no_sync_cmos_clock)
 		mod_timer(&sync_cmos_timer, jiffies + 1);
 }
 

Yours Tony

  linux.conf.au        http://linux.conf.au/ || http://lca2008.linux.org.au/
  Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!

             reply	other threads:[~2007-09-11  7:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-11  7:46 Tony Breeds [this message]
2007-09-11  7:57 ` Fix "no_sync_cmos_clock" logic inversion in kernel/time/ntp.c Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070911074608.GD9814@bakeyournoodle.com \
    --to=tony@bakeyournoodle$(echo .)com \
    --cc=akpm@linux-foundation$(echo .)org \
    --cc=johnstul@us$(echo .)ibm.com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=paulus@samba$(echo .)org \
    --cc=tglx@linutronix$(echo .)de \
    --cc=zach@vmware$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox