From: Joachim Fenkes <fenkes@de•ibm.com>
To: Nathan Lynch <ntl@pobox•com>
Cc: LKML <linux-kernel@vger•kernel.org>,
OF-EWG <ewg@lists•openfabrics.org>,
LinuxPPC-Dev <linuxppc-dev@ozlabs•org>,
Christoph Raisch <raisch@de•ibm.com>,
OF-General <general@lists•openfabrics.org>,
Stefan Roscher <stefan.roscher@de•ibm.com>
Subject: Re: [PATCH 08/12] IB/ehca: Replace get_paca()->paca_index by the more portable smp_processor_id()
Date: Wed, 12 Sep 2007 16:42:50 +0200 [thread overview]
Message-ID: <200709121642.51198.fenkes@de.ibm.com> (raw)
In-Reply-To: <20070911145131.GN32388@localdomain>
On Tuesday 11 September 2007 16:51, Nathan Lynch wrote:
> > - get_paca()->paca_index, __FUNCTION__, \
> > + smp_processor_id(), __FUNCTION__, \
>
> I think I see these macros used in preemptible code (e.g. ehca_probe),
> where smp_processor_id() will print a warning when
> CONFIG_DEBUG_PREEMPT=y. Probably better to use raw_smp_processor_id.
You're right, man. The processor id doesn't need to be preemption-safe in this
context, so that would be a bogus warning. Thanks for pointing this out. I'll
post a new version of this patch.
Joachim
next prev parent reply other threads:[~2007-09-12 14:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 13:18 [PATCH 00/12] IB/ehca: New features and fixes for 2.6.24 Joachim Fenkes
2007-09-11 13:26 ` [PATCH 01/12] IB/ehca: Small QP userspace support Joachim Fenkes
2007-09-11 13:29 ` [PATCH 02/12] IB/ehca: Add 1 is not longer needed because of firmware interface change Joachim Fenkes
2007-09-12 20:21 ` Roland Dreier
2007-09-14 13:48 ` Joachim Fenkes
2007-09-14 16:05 ` Roland Dreier
2007-09-11 13:29 ` [PATCH 03/12] IB/ehca: Support more than 4k QPs for userspace and kernelspace Joachim Fenkes
2007-09-11 13:31 ` [PATCH 04/12] IB/ehca: Use remap_4k_pfn() to map firmware contexts to user space Joachim Fenkes
2007-09-11 13:31 ` [PATCH 05/12] IB/ehca: Refactor hvcall tracing Joachim Fenkes
2007-09-11 13:32 ` [PATCH 06/12] IB/ehca: Print return codes as signed decimal integers Joachim Fenkes
2007-09-11 13:32 ` [PATCH 07/12] IB/ehca: ehca_gen_warn() should always print Joachim Fenkes
2007-09-11 13:33 ` [PATCH 08/12] IB/ehca: Replace get_paca()->paca_index by the more portable smp_processor_id() Joachim Fenkes
2007-09-11 14:51 ` Nathan Lynch
2007-09-12 14:42 ` Joachim Fenkes [this message]
2007-09-12 14:44 ` [PATCH 08/12] IB/ehca: Replace get_paca()->paca_index by the more portable raw_smp_processor_id() Joachim Fenkes
2007-09-11 13:33 ` [PATCH 09/12] IB/ehca: Add check for max #SGE to create_qp() Joachim Fenkes
2007-09-11 13:34 ` [PATCH 10/12] IB/ehca: Path migration support Joachim Fenkes
2007-09-11 13:34 ` [PATCH 11/12] IB/ehca: Serialize MR alloc and MR free hvCalls Joachim Fenkes
2007-09-11 13:35 ` [PATCH 12/12] IB/ehca: Bump version number and change its format Joachim Fenkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709121642.51198.fenkes@de.ibm.com \
--to=fenkes@de$(echo .)ibm.com \
--cc=ewg@lists$(echo .)openfabrics.org \
--cc=general@lists$(echo .)openfabrics.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=ntl@pobox$(echo .)com \
--cc=raisch@de$(echo .)ibm.com \
--cc=stefan.roscher@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox