Subject: Re: [PATCH] i2c: devtree-aware iic support for PPC4xx

From: Stefan Roese <[email-masked]>
Date: Sun, 16 Sep 2007 11:07:23 +0200

On Saturday 15 September 2007, Vitaly Bordug wrote:
> > Where is dev->clkdiv initialized?
> >
> > My original version used iic_clkdiv() to calculate correct devider
> > based on OPB frequency. Did you even test this code?

Yes, I tested it successfully on the Sequoia eval board.

> heh, just my $0.02: the upper clearly shows one like missing, maybe during
> cleanup (since there is opb freq pulled in quote):
>
>         dev->clckdiv = iic_clckdiv(*prop); or smth like that

Could be. Thanks for the hint. I'll take a look at it an resubmit.

Best regards,
Stefan