From: Robert Schwebel <r.schwebel@pengutronix•de>
To: Stefan Roese <sr@denx•de>
Cc: Jean Delvare <khali@linux-fr•org>,
linuxppc-dev@ozlabs•org, i2c@lm-sensors•org
Subject: Re: [PATCH] i2c: devtree-aware iic support for PPC4xx
Date: Sun, 16 Sep 2007 18:27:47 +0200 [thread overview]
Message-ID: <20070916162747.GV23573@pengutronix.de> (raw)
In-Reply-To: <200709161352.03459.sr@denx.de>
On Sun, Sep 16, 2007 at 01:52:02PM +0200, Stefan Roese wrote:
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> index 9f3a4cd..12453e2 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -220,7 +220,17 @@ config I2C_PIIX4
>
> config I2C_IBM_IIC
> tristate "IBM PPC 4xx on-chip I2C interface"
> - depends on IBM_OCP
> + depends on !PPC_MERGE
> + help
> + Say Y here if you want to use IIC peripheral found on
> + embedded IBM PPC 4xx based systems.
Can we agree on one nomenclature - either i2c or iic?
> + This driver can also be built as a module. If so, the module
> + will be called i2c-ibm_iic.
Are these drivers the same functionality (host i2c driver for 4xx)? If
yes, shouldn't all in-tree users be migrated over and the old style
driver be removed (with deprecation period)?
> +#define DBG_LEVEL 0
> +
> +#ifdef DBG
> +#undef DBG
> +#endif
> +
> +#ifdef DBG2
> +#undef DBG2
> +#endif
> +
> +#if DBG_LEVEL > 0
> +# define DBG(f,x...) printk(KERN_DEBUG "ibm-iic" f, ##x)
> +#else
> +# define DBG(f,x...) ((void)0)
> +#endif
> +#if DBG_LEVEL > 1
> +# define DBG2(f,x...) DBG(f, ##x)
> +#else
> +# define DBG2(f,x...) ((void)0)
> +#endif
Any reason why you can't use pr_debug?
Robert
--
Pengutronix - Linux Solutions for Science and Industry
Entwicklungszentrum Nord http://www.pengutronix.de
next prev parent reply other threads:[~2007-09-16 16:27 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 11:52 [PATCH] i2c: devtree-aware iic support for PPC4xx Stefan Roese
2007-09-16 16:27 ` Robert Schwebel [this message]
2007-09-16 16:37 ` Josh Boyer
2007-09-17 1:32 ` David Gibson
2007-09-16 18:53 ` Eugene Surovegin
2007-09-17 1:31 ` David Gibson
2007-09-17 5:34 ` Stefan Roese
2007-09-17 5:50 ` David Gibson
2007-09-17 6:22 ` Eugene Surovegin
2007-09-17 18:16 ` Jean Delvare
2007-09-17 19:27 ` Grant Likely
-- strict thread matches above, loose matches on Subject: below --
2007-09-15 9:08 Stefan Roese
2007-09-15 10:04 ` Eugene Surovegin
2007-09-15 11:29 ` Vitaly Bordug
2007-09-16 9:07 ` Stefan Roese
2007-09-16 18:55 ` Eugene Surovegin
2007-09-15 11:36 ` Stephen Rothwell
2007-09-16 9:08 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070916162747.GV23573@pengutronix.de \
--to=r.schwebel@pengutronix$(echo .)de \
--cc=i2c@lm-sensors$(echo .)org \
--cc=khali@linux-fr$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sr@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox