From: Domen Puncer <domen.puncer@telargo•com>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: Domen's MPC5200 FEC cleanup patch.
Date: Mon, 17 Sep 2007 07:33:14 +0200 [thread overview]
Message-ID: <20070917053314.GA19538@nd47.coderock.org> (raw)
In-Reply-To: <9e4733910709161205k15106ba1sd2f0597f2601f222@mail.gmail.com>
On 16/09/07 15:05 -0400, Jon Smirl wrote:
> This adjustment to the error counting is in the Efika patches and not
> in yours, should it be in yours too?
I know about this patch.
Error counting is reworked in newer anyway (mixing rmon and ieee
counters didn't look very nice to me).
Domen
>
> --- a/drivers/net/fec_mpc52xx/fec.c 2007-05-30 16:04:50.000000000 +0200
> +++ b/drivers/net/fec_mpc52xx/fec.c 2007-05-30 16:09:02.000000000 +0200
> @@ -411,7 +411,9 @@
>
> stats->rx_bytes = in_be32(&fec->rmon_r_octets);
> stats->rx_packets = in_be32(&fec->rmon_r_packets);
> - stats->rx_errors = stats->rx_packets - in_be32(&fec->ieee_r_frame_ok);
> + stats->rx_errors = stats->rx_packets - (
> + in_be32(&fec->ieee_r_frame_ok) +
> + in_be32(&fec->rmon_r_mc_pkt));
> stats->tx_bytes = in_be32(&fec->rmon_t_octets);
> stats->tx_packets = in_be32(&fec->rmon_t_packets);
> stats->tx_errors = stats->tx_packets - (
>
> --
> Jon Smirl
> jonsmirl@gmail•com
prev parent reply other threads:[~2007-09-17 5:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-15 3:38 Domen's MPC5200 FEC cleanup patch Jon Smirl
2007-09-15 4:28 ` Jon Smirl
2007-09-15 12:22 ` Domen Puncer
2007-09-15 15:55 ` Jon Smirl
2007-09-16 17:00 ` Jon Smirl
2007-09-16 17:05 ` Jon Smirl
2007-09-16 18:00 ` Jon Smirl
2007-09-16 18:25 ` Jon Smirl
2007-09-16 18:34 ` Robert Schwebel
2007-09-16 18:38 ` Jon Smirl
2007-09-16 18:50 ` Robert Schwebel
2007-09-16 18:54 ` Jon Smirl
2007-09-16 18:42 ` Jeff Mock
2007-09-16 19:05 ` Jon Smirl
2007-09-17 5:33 ` Domen Puncer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917053314.GA19538@nd47.coderock.org \
--to=domen.puncer@telargo$(echo .)com \
--cc=jonsmirl@gmail$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox