From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: paulus@samba•org
Subject: Re: [PATCH 4/7] Celleb: New HTAB Guest OS Interface on Beat
Date: Thu, 27 Sep 2007 10:51:58 +0200 [thread overview]
Message-ID: <200709271051.59180.arnd@arndb.de> (raw)
In-Reply-To: <20070927.165326.-1300536104.kouish@swc.toshiba.co.jp>
On Thursday 27 September 2007, Ishizaki Kou wrote:
> This is a patch kit to work with new Guest OS Interface
> to tweak HTAB on Beat. It detects old and new Guest OS Interfaces
> automatically.
>
> Signed-off-by: Kou Ishizaki <Kou.Ishizaki@toshiba•co.jp>
Acked-by: Arnd Bergmann <arnd.bergmann@de•ibm.com>
The code looks good. One possible optimization I can imagine is
to split the v3 functions and the older versions into separate
source files, and then use configuration options to decide if
you want to build a kernel just for one of the two, or for
both variants. You could even have two separate machine descriptions,
while still sharing most of the platform code in common files.
Arnd <><
prev parent reply other threads:[~2007-09-27 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 7:53 [PATCH 4/7] Celleb: New HTAB Guest OS Interface on Beat Ishizaki Kou
2007-09-27 8:31 ` Benjamin Herrenschmidt
2007-09-28 6:54 ` Ishizaki Kou
2007-09-27 8:51 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709271051.59180.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox