From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: paulus@samba•org
Subject: Re: [PATCH 5/7] Celleb: Supports VFD on Celleb 2
Date: Thu, 27 Sep 2007 11:07:33 +0200 [thread overview]
Message-ID: <200709271107.33696.arnd@arndb.de> (raw)
In-Reply-To: <20070927.165631.-1300533671.kouish@swc.toshiba.co.jp>
On Thursday 27 September 2007, Ishizaki Kou wrote:
> This is a patch to support VFD on Celleb 2.
> VFD is a small LCD to show miscellaneous messages.
>
> Signed-off-by: Kou Ishizaki <Kou.Ishizaki@toshiba•co.jp>
The implementation looks fine, but I'm not sure if /proc/ppc64/rtas is the
right way to do it. The two problems I have with this are:
* /proc files are generally not a good idea for new stuff. We carry around
the existing /proc/ppc64/rtas files because we can't change the interface
for existing stuff. My feeling is that your interface should better be
implemented as a character device, or be integrating into some other
existing message interface, if we can find one.
* The firmware seems to implement the generic rtas interface for
display-character and set-indicator, but your driver is celleb specific.
I'd be feel more comfortable if we could come up with a driver that also
works on other systems that implement the same rtas calls.
Arnd <><
next prev parent reply other threads:[~2007-09-27 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 7:56 [PATCH 5/7] Celleb: Supports VFD on Celleb 2 Ishizaki Kou
2007-09-27 9:07 ` Arnd Bergmann [this message]
2007-09-27 16:54 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709271107.33696.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox