Subject: Re: [PATCH 01/18] Virtex: Add uartlite bootwrapper driver

From: Arnd Bergmann <[email-masked]>
Date: Fri, 28 Sep 2007 21:45:08 +0200

On Friday 28 September 2007, Grant Likely wrote:
> +static void uartlite_putc(unsigned char c)
> +{
> +=A0=A0=A0=A0=A0=A0=A0while ((in_be32(reg_base + 0x8) & 0x08) !=3D 0); /*=
 spin */
> +=A0=A0=A0=A0=A0=A0=A0out_be32(reg_base + 0x4, c);
> +}

When coding a spin-loop, it's better to do a cpu_relax() between
each attempt.

	Arnd <><