Subject: Re: [PATCH 2/3] [POWERPC] Add AMCC Kilauea eval board support to platforms/40x

From: Stefan Roese <[email-masked]>
Date: Tue, 9 Oct 2007 13:34:16 +0200

Hi Olof,

On Monday 08 October 2007, Olof Johansson wrote:
> > +config KILAUEA
> > +	bool "Kilauea"
> > +	depends on 40x
> > +	default y
> > +	select 405EX
> > +	help
> > +	  This option enables support for the AMCC PPC405EX evaluation board.
> > +
> >  #config REDWOOD_5
> >  #	bool "Redwood-5"
> >  #	depends on 40x
> > @@ -89,14 +97,17 @@ config 403GCX
> >  	#depends on OAK
> >  	select IBM405_ERR51
> >
> > +config 405EP
> > +	bool
> > +
> > +config 405EX
> > +	bool
> > +
>
> Do you really need config options for 405EP/EX? I don't seem them used
> anywhere else in the code (and it's also contradictory to the whole new
> multiplatform way of looking at stuff :).
>
> I know the 405/440 is still somewhat #ifdef:ed on the cpu here and there,
> but since this doesn't add any such code I don't see a need for the config
> options?

Yes, I'm still used to needing these defines from arch/ppc (for example for 
the 4xx EMAC driver). But its possible, that we really don't need it at all 
in arch/powerpc with all the device tree information. Not sure though.

Josh, what do you think? Should I remove the 405EX define completely?

Best regards,
Stefan