Subject: Re: [PATCH v2 2/2] [POWERPC] MPC8568E-MDS: add support for flash

From: David Gibson <[email-masked]>
Date: Tue, 16 Oct 2007 11:12:30 +1000

On Mon, Oct 15, 2007 at 01:00:24PM -0500, Kumar Gala wrote:
> 
> On Oct 15, 2007, at 12:33 PM, Sergei Shtylyov wrote:
> 
> > Anton Vorontsov wrote:
> >
> >> MPC8568E-MDS have 1 32MB Spansion x16 CFI flash chip. Let's use it.
> >
> >> Signed-off-by: Anton Vorontsov <[email-masked]>
> >
> >> diff --git a/arch/powerpc/boot/dts/mpc8568mds.dts b/arch/powerpc/ 
> >> boot/dts/mpc8568mds.dts
> >> index 8e15dba..1198363 100644
> >> --- a/arch/powerpc/boot/dts/mpc8568mds.dts
> >> +++ b/arch/powerpc/boot/dts/mpc8568mds.dts
> >> @@ -47,12 +47,45 @@
> >>  		#address-cells = <2>;
> >>  		#size-cells = <1>;
> >>  		reg = <e0005000 d8>;
> >> -		ranges = <1 0 f8000000 0008000>;
> >> +		ranges = <1 0 f8000000 0008000
> >> +			  0 0 fe000000 2000000>;
> >>
> >>  		bcsr@1,0 {
> >>  			device_type = "board-control";
> >>  			reg = <1 0 8000>;
> >>  		};
> >> +
> >> +		flash@0,0 {
> >> +			compatible = "Spansion,S29GL256N11TFIV2O", "cfi-flash";
> >> +			reg = <0 0 2000000>;
> >> +			probe-type = "CFI";
> >
> >     I don't get it -- has physmap_of.c rewrite been already committed?
> > If yes, you don't need probe_type; if no, your "compatible" won't  
> > work...
> > Well, I see that the driver rewrite has been committed (when I  
> > wasn't looking
> > 8-)...
> 
> Any NOR flash nodes should conform to the "new" bindings from David  
> Gibson, et al.  Not sure about the status of those being in  
> physmap_of.c w/regards to 2.6.24.

Yes, in which case probe_type should be dropped, as should the low bit
in the read-only partitions.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson