Subject: Re: [PATCH 07/15] [POWERPC] Promess Motion-PRO DTS

From: David Gibson <[email-masked]>
Date: Thu, 18 Oct 2007 22:54:40 +1000

On Thu, Oct 18, 2007 at 02:50:11PM +0200, Wolfgang Grandegger wrote:
> Hello,
> 
> I see one more issue.
> 
> Marian Balakowicz wrote:
> > Add device tree source file for Motion-PRO board.
> > 
> > Signed-off-by: Marian Balakowicz <[email-masked]>
> > ---
> [deletions]
> > +		gpio@b00 {
> > +			compatible = "mpc5200b-gpio\0mpc5200-gpio";
> > +			reg = <b00 40>;
> > +			interrupts = <1 7 0>;
> > +			interrupt-parent = <&mpc5200_pic>;
> > +		};
> 
> Do we not need the field "device_type = "gpio" here?

No, we really don't.  If there's any "class" of devices that *don't*
deserve a device_type it would be gpios.

Oh, also dtc can now do the compatible properties as:
	compatible = "mpc5200b-gpio", "mpc5200-gpio";

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson