From: Olof Johansson <olof@lixom•net>
To: Stephen Rothwell <sfr@canb•auug.org.au>
Cc: ppc-dev <linuxppc-dev@ozlabs•org>,
Andrew Morton <akpm@linux-foundation•org>
Subject: Re: [PATCH] NULL terminate the pci_device_ids in pasemi_edac
Date: Fri, 19 Oct 2007 01:47:25 -0500 [thread overview]
Message-ID: <20071019064725.GA1806@lixom.net> (raw)
In-Reply-To: <20071019150722.8d48eb1d.sfr@canb.auug.org.au>
On Fri, Oct 19, 2007 at 03:07:22PM +1000, Stephen Rothwell wrote:
> Fixes:
> drivers/edac/pasemi_edac: struct pci_device_id is 32 bytes. The last of 1 is:
> 0x00 0x00 0x19 0x59 0x00 0x00 0xa0 0x0a 0xff 0xff 0xff 0xff 0xff 0xff 0xff 0xff
> 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
> FATAL: drivers/edac/pasemi_edac: struct pci_device_id is not terminated with a NULL entry!
>
> Signed-off-by: Stephen Rothwell <sfr@canb•auug.org.au>
Acked-by: Olof Johansson <olof@lixom•net>
Thanks for fixing this, Stephen. ID lists without termination can really
cause weird problems at the most random times since it depends on how
the kernel is built whether they do any (immediate) harm or not.
-Olof
next prev parent reply other threads:[~2007-10-19 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-19 5:07 [PATCH] NULL terminate the pci_device_ids in pasemi_edac Stephen Rothwell
2007-10-19 6:47 ` Olof Johansson [this message]
2007-10-19 10:34 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071019064725.GA1806@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox