Subject: Re: [PATCH] Prevent appletouch message log spam on 17" PB

From: Dmitry Torokhov <[email-masked]>
Date: Sun, 28 Oct 2007 22:21:25 -0400

Hi Joseph,

On Sunday 28 October 2007 19:53, Joseph Jezak wrote:
> Perhaps this was a debugging message?  In any case, this printk
> causes lots of message log spam on my PB G4 1.67" (PowerBook5,9).
> 
> This removes the printk.
> 

I don't think we want do delete this message outright, we just need
to make sure we don't go through size detection when we re-initialize
the device. After all it is unlikely that touchpad will change its
size :)

BTW, could you tell me what product ID your touchpad has?

> Signed-off by: Joseph Jezak <[email-masked]>
> ---
> 
> diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
> index f132702..6c47641 100644
> --- a/drivers/input/mouse/appletouch.c
> +++ b/drivers/input/mouse/appletouch.c
> @@ -433,7 +433,6 @@ static void atp_complete(struct urb* urb)
>  		for (i = (atp_is_geyser_2(dev)?15:16); i < ATP_XSENSORS; i++) {
>  			if (!dev->xy_cur[i]) continue;
>  
> -			printk("appletouch: 17\" model detected.\n");
>  			if(atp_is_geyser_2(dev))
>  				input_set_abs_params(dev->input, ABS_X, 0,
>  						     (20 - 1) *
> 

-- 
Dmitry