From: Olof Johansson <olof@lixom•net>
To: Paul Mackerras <paulus@samba•org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [POWERPC] Fix off-by-one error in setting decrementer on Book E
Date: Sun, 28 Oct 2007 22:16:21 -0500 [thread overview]
Message-ID: <20071029031620.GA14667@lixom.net> (raw)
In-Reply-To: <18213.19469.827909.663373@cargo.ozlabs.ibm.com>
Hi Paul,
On Mon, Oct 29, 2007 at 01:57:17PM +1100, Paul Mackerras wrote:
> diff --git a/include/asm-powerpc/time.h b/include/asm-powerpc/time.h
> index f058955..eed64bd 100644
> --- a/include/asm-powerpc/time.h
> +++ b/include/asm-powerpc/time.h
> @@ -183,6 +183,7 @@ static inline void set_dec(int val)
> #elif defined(CONFIG_8xx_CPU6)
> set_dec_cpu6(val);
> #else
> + --val; /* classic decrementer interrupts when dec goes negative */
> #ifdef CONFIG_PPC_ISERIES
> int cur_dec;
This will mix code and declarations, I think some toolchains complain
about that?
It doesn't look like cur_dec is really needed, the call can be inlined
directly where it's used.
-Olof
next prev parent reply other threads:[~2007-10-29 3:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 2:57 [POWERPC] Fix off-by-one error in setting decrementer on Book E Paul Mackerras
2007-10-29 3:10 ` Paul Mackerras
2007-10-29 3:16 ` Olof Johansson [this message]
2007-10-29 16:52 ` Sergei Shtylyov
2007-10-31 9:40 ` Paul Mackerras
2007-10-31 14:12 ` Sergei Shtylyov
2007-10-30 3:52 ` Kumar Gala
2007-10-30 14:23 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029031620.GA14667@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox