Subject: Re: [PATCH 2/4] PowerPC: 440GRx Rainier DTS.

From: David Gibson <[email-masked]>
Date: Wed, 31 Oct 2007 10:08:05 +1100

On Tue, Oct 30, 2007 at 07:56:50PM +0300, Valentine Barshak wrote:
> PowerPC 440GRx Rainier DTS.
[snip]
> +		SDRAM0: sdram {
> +			device_type = "memory-controller";

How many times do we need to say it...

Don't make up random device_type values.  This does not belong here.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson