Subject: Re: [PATCH 1/3] Add remove_memory() for ppc64

From: "Dale Farnsworth" <[email-masked]>
Date: 31 Oct 2007 14:47:54 -0700

Badari Pulavarty wrote:
> On Thu, 2007-11-01 at 01:26 -0500, Kumar Gala wrote:
> > On Oct 31, 2007, at 11:49 AM, Badari Pulavarty wrote:
> > 
> > > Supply arch specific remove_memory() for PPC64. There is nothing
> > > ppc specific code here and its exactly same as ia64 version.
> > > For now, lets keep it arch specific - so each arch can add
> > > its own special things if needed.
> > >
> > > Signed-off-by: Badari Pulavarty <[email-masked]>
> > > ---
> > 
> > What's ppc64 specific about these patches?
> 
> Like I mentioned, nothing. When KAME did the hotplug memory
> remove, he kept this remove_memory() arch-specific - so
> each arch can provide its own, if it needs to something
> special. So far, there is no need for arch-specific 
> remove_memory(). If other archs (x86-64 and others)
> agree we can merge this into arch neutral code.
> 
> I have to provide this for ppc64 to plug into general
> frame work.

You've added it to arch/powerpc for both PPC32 and PPC64, so your
commit description is misleading.

-Dale