From: linas@austin•ibm.com (Linas Vepstas)
To: Paul Mackerras <paulus@samba•org>
Cc: ppc-dev <linuxppc-dev@ozlabs•org>
Subject: [PATCH 1/3] powerpc eeh: cleanup comments
Date: Fri, 2 Nov 2007 15:25:55 -0500 [thread overview]
Message-ID: <20071102202555.GA13828@austin.ibm.com> (raw)
In-Reply-To: <20071102201957.GU2183@austin.ibm.com>
Clean up commentary, remove dead code.
Signed-off-by Linas Vepstas <linas@austin•ibm.com>
----
arch/powerpc/platforms/pseries/eeh_driver.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
Index: linux-2.6.23-rc8-mm1/arch/powerpc/platforms/pseries/eeh_driver.c
===================================================================
--- linux-2.6.23-rc8-mm1.orig/arch/powerpc/platforms/pseries/eeh_driver.c 2007-10-16 11:39:18.000000000 -0500
+++ linux-2.6.23-rc8-mm1/arch/powerpc/platforms/pseries/eeh_driver.c 2007-10-16 11:46:30.000000000 -0500
@@ -113,9 +113,9 @@ static void eeh_report_error(struct pci_
/**
* eeh_report_mmio_enabled - tell drivers that MMIO has been enabled
*
- * Report an EEH error to each device driver, collect up and
- * merge the device driver responses. Cumulative response
- * passed back in "userdata".
+ * Tells each device driver that IO ports, MMIO and config space I/O
+ * are now enabled. Collects up and merges the device driver responses.
+ * Cumulative response passed back in "userdata".
*/
static void eeh_report_mmio_enabled(struct pci_dev *dev, void *userdata)
@@ -123,8 +123,6 @@ static void eeh_report_mmio_enabled(stru
enum pci_ers_result rc, *res = userdata;
struct pci_driver *driver = dev->driver;
- // dev->error_state = pci_channel_mmio_enabled;
-
if (!driver ||
!driver->err_handler ||
!driver->err_handler->mmio_enabled)
next prev parent reply other threads:[~2007-11-02 20:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 20:19 [PATCH 0/3] powerpc eeh: bug fixes for crashes, bad handling Linas Vepstas
2007-11-02 20:25 ` Linas Vepstas [this message]
2007-11-02 20:27 ` [PATCH 2/3]: powerpc eeh: drivers that need reset trump others Linas Vepstas
2007-11-02 20:29 ` [PATCH 3/3]: powerpc eeh: avoid crash on null device Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071102202555.GA13828@austin.ibm.com \
--to=linas@austin$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox