Subject: Re: [PATCH v2 08/12] [POWERPC] CM5200 DTS

From: David Gibson <[email-masked]>
Date: Mon, 5 Nov 2007 11:50:07 +1100

On Sun, Nov 04, 2007 at 12:52:59AM +0100, Marian Balakowicz wrote:
> Add device tree source file for CM5200 board.
> 
> Signed-off-by: Marian Balakowicz <[email-masked]>

Same comments as the TQM device tree, plus those below.

[snip]
> +		rtc@800 {	// Real time clock
> +			compatible = "mpc5200b-rtc","mpc5200-rtc";
> +			device_type = "rtc";

No device_type here.

[snip]
> +		spi@f00 {
> +			device_type = "spi";

Definitely no device_type here.

> +			compatible = "mpc5200b-spi","mpc5200-spi";
> +			reg = <f00 20>;
> +			interrupts = <2 d 0 2 e 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +		};

[snip]
> +		i2c@3d40 {
> +			device_type = "i2c";

No device_type here.

> +			compatible = "mpc5200b-i2c","mpc5200-i2c","fsl-i2c";
> +			reg = <3d40 40>;
> +			interrupts = <2 10 0>;
> +			interrupt-parent = <&mpc5200_pic>;
> +			fsl5200-clocking;
> +		};
> +
> +		sram@8000 {
> +			compatible = "mpc5200b-sram","mpc5200-sram","sram";
> +			reg = <8000 4000>;
> +		};
> +	};
> +};

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson