From: Olof Johansson <olof@lixom•net>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, Doug Thompson <dougthompson@xmission•com>
Subject: Re: [PATCH] [POWERPC] pasemi: Broaden specific references to 1682M
Date: Mon, 5 Nov 2007 20:01:39 -0600 [thread overview]
Message-ID: <20071106020139.GA2297@lixom.net> (raw)
In-Reply-To: <cd9a9e67893406e486d2ffc7599e28b7@kernel.crashing.org>
On Tue, Nov 06, 2007 at 02:42:08AM +0100, Segher Boessenkool wrote:
> Hi Olof,
>
> Nice cleanup! One minor thing...
>
>> static struct of_device_id pasemi_bus_ids[] = {
>> + /* Unfortunately needed for legacy firmwares */
>> { .type = "localbus", },
>> { .type = "sdc", },
>> + { .compatible = "pasemi,localbus", },
>> + { .compatible = "pasemi,sdc", },
>
> The new comment is for the device_type entries only, right? You
> might want to make that more clear.
Good point. I'll clarify it with a new comment above the compatible
entries. I won't repost the patch since the change is minor, but include
it for the upstream push.
Thanks,
-Olof
prev parent reply other threads:[~2007-11-06 1:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 3:28 [PATCH] [POWERPC] pasemi: Broaden specific references to 1682M Olof Johansson
2007-11-05 12:55 ` Michael Buesch
2007-11-05 18:57 ` Doug Thompson
2007-11-05 19:22 ` Olof Johansson
2007-11-06 1:42 ` Segher Boessenkool
2007-11-06 2:01 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071106020139.GA2297@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=dougthompson@xmission$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox