From: Olof Johansson <olof@lixom•net>
To: Paul Mackerras <paulus@samba•org>
Cc: dwmw2@infradead•org, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2] [POWERPC] vdso: Fixes for cache block sizes
Date: Sun, 18 Nov 2007 22:25:19 -0600 [thread overview]
Message-ID: <20071119042519.GA28872@lixom.net> (raw)
In-Reply-To: <18241.3066.346441.180033@cargo.ozlabs.ibm.com>
On Mon, Nov 19, 2007 at 03:07:22PM +1100, Paul Mackerras wrote:
> Olof Johansson writes:
>
> > [POWERPC] vdso: Fixes for cache line sizes
> >
> > Current VDSO implementation is hardcoded to 128 byte cache blocks,
> > which are only used on IBM's 64-bit processors.
> >
> > Convert it to get the blocks sizes out of vdso_data instead, similar
> > to how the ppc64 in-kernel cache flush does it.
>
> OK, but you have removed a "crclr cr0*4+so" instruction in a couple of
> places. They are there so that the functions follow the convention
> for system calls, where cr0.SO set on return indicates an error, and
> clear indicates no error. Was there any special reason why you
> removed them? If not, please put them back (after the last cmp or
> dot-form instruction).
Good catch. They must have fallen off when I copied over the in-kernel
versions. I'll repost tomorrow.
Thanks,
-Olof
next prev parent reply other threads:[~2007-11-19 4:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 19:24 [PATCH] [POWERPC] vdso: Fixes for cache line sizes Olof Johansson
2007-11-14 20:28 ` Benjamin Herrenschmidt
2007-11-14 21:28 ` [PATCH v2] [POWERPC] vdso: Fixes for cache block sizes Olof Johansson
2007-11-19 4:07 ` Paul Mackerras
2007-11-19 4:25 ` Olof Johansson [this message]
2007-11-20 1:24 ` [PATCH v3] " Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071119042519.GA28872@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=dwmw2@infradead$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox