public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Dale Farnsworth <dale@farnsworth•org>
To: linuxppc-dev@ozlabs•org
Subject: [PATCH 10/10] powerpc: Make crashkernels ignore crashkernel reservations
Date: Thu, 22 Nov 2007 08:46:54 -0700	[thread overview]
Message-ID: <20071122154654.GA26570@xyzzy.farnsworth.org> (raw)
In-Reply-To: <20071122154159.GA24711@xyzzy.farnsworth.org>

If a user requests a crash kernel to reserve crashkernel memory,
the kernel fails to boot.  While the user shouldn't do that, it
is easy to check for and makes it possible to use the same command
line for crash kernels as for the initial kernel.

Signed-off-by: Dale Farnsworth <dale@farnsworth•org>
---
 arch/powerpc/kernel/machine_kexec.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
index 38c1c1a..733726a 100644
--- a/arch/powerpc/kernel/machine_kexec.c
+++ b/arch/powerpc/kernel/machine_kexec.c
@@ -94,6 +94,14 @@ void __init reserve_crashkernel(void)
 		printk("Crash kernel location must be 0x%x\n",
 				KDUMP_KERNELBASE);
 
+	if (PHYSICAL_START == KDUMP_KERNELBASE) {
+		printk("Already running a crashkernel, "
+			"ignoring crashkernel reservation\n");
+		crashk_res.start = 0;
+		crashk_res.end = 0;
+		return;
+	}
+
 	crashk_res.start = KDUMP_KERNELBASE;
 	crash_size = PAGE_ALIGN(crash_size);
 	crashk_res.end = crashk_res.start + crash_size - 1;
-- 
1.5.3.4

  parent reply	other threads:[~2007-11-22 15:46 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <foo@xyzzy.farnsworth.org>
2007-11-22 15:42 ` [PATCH 00/10] powerpc: Add kexec/kdump support for ppc32 Dale Farnsworth
2007-11-22 15:45   ` [PATCH 01/10] powerpc: Set up OF properties for ppc32 kexec Dale Farnsworth
2007-11-22 22:17     ` Stephen Rothwell
2007-11-23  4:43       ` Dale Farnsworth
2007-11-22 15:46   ` [PATCH 02/10] powerpc: Cleanup CONFIG_KEXEC dependency Dale Farnsworth
2007-11-22 15:46   ` [PATCH 03/10] powerpc: Add kexec support for PPC_85xx platforms Dale Farnsworth
2007-11-22 22:20     ` Stephen Rothwell
2007-12-15  6:16     ` Benjamin Herrenschmidt
2007-12-18 16:14       ` Dale Farnsworth
2007-11-22 15:46   ` [PATCH 04/10] powerpc: Add crash kernel support for classic ppc Dale Farnsworth
2007-11-22 15:46   ` [PATCH 05/10] powerpc: Add crash kernel support for 85xx Dale Farnsworth
2007-12-14 16:48     ` Kumar Gala
2007-12-14 17:23       ` Dale Farnsworth
2008-01-18 22:29         ` Kumar Gala
2008-01-18 23:09           ` Dale Farnsworth
2008-01-21 16:19     ` Kumar Gala
2007-11-22 15:46   ` [PATCH 06/10] powerpc: Fix bogus crash kernel messages Dale Farnsworth
2007-11-22 15:46   ` [PATCH 07/10] powerpc: Implement kmap_atomic_pfn on powerpc Dale Farnsworth
2007-12-15  6:17     ` Benjamin Herrenschmidt
2007-12-18 16:20       ` Dale Farnsworth
2007-12-18 16:42         ` Kumar Gala
2007-11-22 15:46   ` [PATCH 08/10] powerpc: Implement crash dump support on ppc32 Dale Farnsworth
2007-11-22 15:46   ` [PATCH 09/10] powepc: Remove unnecessary of_get_flat_dt_prop casts Dale Farnsworth
2007-11-22 15:46   ` Dale Farnsworth [this message]
2008-04-24 12:50   ` [PATCH 00/10] powerpc: Add kexec/kdump support for ppc32 Kumar Gala
2008-04-24 15:42     ` Dale Farnsworth
2008-04-24 16:28       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071122154654.GA26570@xyzzy.farnsworth.org \
    --to=dale@farnsworth$(echo .)org \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox