From: David Brownell <david-b@pacbell•net>
To: "Grant Likely" <grant.likely@secretlab•ca>
Cc: akpm@osdl•org, linuxppc-dev@ozlabs•org, gregkh@suse•de,
linux-usb-devel@lists•sourceforge.net
Subject: Re: [PATCH 5/5] USB: Add Cypress c67x00 OTG controller driver to Kconfig and Makefiles
Date: Sat, 24 Nov 2007 13:03:31 -0800 [thread overview]
Message-ID: <200711241303.31700.david-b@pacbell.net> (raw)
In-Reply-To: <fa686aa40711241220r4e808ad8obb27ae8bf5890048@mail.gmail.com>
On Saturday 24 November 2007, Grant Likely wrote:
> On 11/24/07, David Brownell <david-b@pacbell•net> wrote:
> > On Friday 23 November 2007, Grant Likely wrote:
> > > +config USB_C67X00_DRV
> > > +tristate "Cypress C67x00 support"
> > > +# only allowed to be =y if both USB!=m and USB_GADGET!=m
> >
> > This is wrong. Remember that since this is a dual-role driver,
> > there are exactly three possible driver modes ... and the driver
> > must support only one of them at a time:
>
> Actually, this part has 2 serial in interface engines; either of which
> can be in host, peripheral or OTG mode. So; it is entirely relevant
> for the driver to be doing both host and peripheral at the same time
> with a single device.
While conforming with USB specs? Has that changed recently?
In the not-too-distant past I know there was explicit language
saying that such configurations are not allowed. (At least,
in terms of external connectors. A board using USB for internal
peripheral connections would be OK.)
Those issues can be deferred until peripheral support exists.
At that point you'll need to get better solutions to those config
issues...
> > Hmmm ... your patches don't include peripheral mode support yet.
>
> No, nobody has written it yet.
Then what's it doing in that GIT tree you pointed me at? :)
> > Either all these gadget hooks should vanish, or you should try
> > to get the controller mode stuff right from the beginning.
> >
> > I've appended the relevant Kconfig bits from the musb_hdrc
> > driver, which (despite some glitches) are pretty much correct.
>
> I'll drop the gadget hooks for now. Most likely gadget and OTG
> support will require more changes to this driver regardless, so it's
> not a big deal.
OK. Then the first incaration of this will be as a host-only
driver, in its own directory, and adding peripheral support will
cause minor lunacy. :)
- Dave
next prev parent reply other threads:[~2007-11-24 21:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-24 0:24 [PATCH 0/5] Review request: Cypress c67x00 OTG controller Grant Likely
2007-11-24 0:24 ` [PATCH 1/5] USB: Make usb_hcd_irq work for multi-role USB controllers w/ shared irq Grant Likely
2007-11-24 5:10 ` Greg KH
2007-11-24 17:03 ` [linux-usb-devel] " Alan Cox
2007-11-24 17:15 ` Grant Likely
2007-11-24 17:50 ` David Brownell
2007-11-24 19:06 ` David Brownell
2007-11-24 19:28 ` Grant Likely
2007-11-24 0:24 ` [PATCH 2/5] USB: Add Cypress c67x00 low level interface code Grant Likely
2007-11-24 19:39 ` David Brownell
2007-11-24 0:24 ` [PATCH 3/5] USB: add Cypress c67x00 OTG controller core driver Grant Likely
2007-11-24 0:24 ` [PATCH 4/5] USB: add Cypress c67x00 OTG controller HCD driver Grant Likely
2007-11-24 3:56 ` [linux-usb-devel] " Alan Stern
2007-11-24 0:24 ` [PATCH 5/5] USB: Add Cypress c67x00 OTG controller driver to Kconfig and Makefiles Grant Likely
2007-11-24 20:12 ` David Brownell
2007-11-24 20:20 ` Grant Likely
2007-11-24 21:03 ` David Brownell [this message]
2007-11-24 21:13 ` Grant Likely
2007-11-24 17:57 ` [PATCH 0/5] Review request: Cypress c67x00 OTG controller David Brownell
2007-11-24 19:27 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200711241303.31700.david-b@pacbell.net \
--to=david-b@pacbell$(echo .)net \
--cc=akpm@osdl$(echo .)org \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=gregkh@suse$(echo .)de \
--cc=linux-usb-devel@lists$(echo .)sourceforge.net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox