Subject: Re: [PATCH] powerpc: fix os-term usage on kernel panic

From: [email-masked] (Linas Vepstas)
Date: Wed, 28 Nov 2007 14:09:32 -0600

On Wed, Nov 28, 2007 at 12:00:37PM +0100, Olaf Hering wrote:
> On Tue, Nov 27, Will Schmidt wrote:
> 
> > > -void rtas_os_term(char *str)
> > > +void rtas_panic_msg(char *str)
> 
> > > -	if (panic_timeout)
> > > -		return;
> 
> This change is wrong. Booting with panic=123 really means the system
> has to reboot in 123 seconds after a panic.

And it does.

> But, maybe this panic_timeout check was moved elsewhere.

It was *always* somewhere else; the check here was always wrong.

This change makes the os-term call happen after the the panic
timeout amount of time has elapsed.

--linas