Subject: Re: [PATCH 1/3] cell: fix undefined reference to mmio_nvram_init

From: Arnd Bergmann <[email-masked]>
Date: Tue, 4 Dec 2007 14:10:42 +0100

On Tuesday 04 December 2007, Ishizaki Kou wrote:
>=20
> +#ifdef CONFIG_MMIO_NVRAM
> =A0=A0=A0=A0=A0=A0=A0=A0mmio_nvram_init();
> +#endif
> =A0}

The patch is technically correct, but the preferred way of doing this is
to define a conditional inline function in the header, like:

#ifdef CONFIG_MMIO_NVRAM
extern int mmio_nvram_init(void);
#else
static inline int mmio_nvram_init(void)
{
	return 0;
}
#endif

so that the caller does not need to know about it.

	Arnd <><