From: Olof Johansson <olof@lixom•net>
To: David Woodhouse <dwmw2@infradead•org>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 2/2] [POWERPC] pasemi: Register i2c_board_info
Date: Tue, 4 Dec 2007 13:32:20 -0600 [thread overview]
Message-ID: <20071204193220.GC5758@lixom.net> (raw)
In-Reply-To: <1196774926.13978.225.camel@pmac.infradead.org>
On Tue, Dec 04, 2007 at 01:28:46PM +0000, David Woodhouse wrote:
>
> On Thu, 2007-11-29 at 21:29 -0600, Olof Johansson wrote:
> > + continue;
> > +
> > + info.addr = *addr;
> > +
> > + i2c_register_board_info(PCI_FUNC(pdev->devfn),
> > &info,
> > + 1);
> > + }
> > + }
>
> + /* Ensure that buses up to 2 are reserved */
> + i2c_register_board_info(2, NULL, 0);
> +
>
>
> > + return 0;
> > +}
> > +device_initcall(pasemi_register_i2c_devices);
> > +#endif
>
>
> Otherwise when you make i2c-pasemi use i2c_add_numbered_adapter(), it
> might fail to register the third bus -- because there were no devices
> preregistered on it, so something else might have stolen that bus number
> already.
Good point, I'd missed that. Thanks!
> You might want to add the patch to use i2c_add_numbered_adapter() to
> your tree, btw.
Yep, I realized that after (re)asking Paul to pull though, and didn't
want to do a third request before he's done it. :)
If he doesn't pull in the next few days I might just keep adding new
patches as they come in though, and add it back.
-Olof
next prev parent reply other threads:[~2007-12-04 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 3:26 [PATCH 1/2] [POWERPC] Consolidate compatible-to-i2c_boardinfo mapping code Olof Johansson
2007-11-30 3:29 ` [PATCH 2/2] [POWERPC] pasemi: Register i2c_board_info Olof Johansson
2007-12-04 13:28 ` David Woodhouse
2007-12-04 19:32 ` Olof Johansson [this message]
2007-12-05 0:41 ` Paul Mackerras
2007-12-05 2:09 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204193220.GC5758@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=dwmw2@infradead$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox