From: Nick Piggin <nickpiggin@yahoo•com.au>
To: Li Zefan <lizf@cn•fujitsu.com>
Cc: linuxppc-dev@ozlabs•org,
Andrew Morton <akpm@linux-foundation•org>,
paulus@samba•org, LKML <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH 1/3] POWERPC: don't cast a pointer to pointer of list_head
Date: Fri, 7 Dec 2007 15:07:09 +1100 [thread overview]
Message-ID: <200712071507.10161.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <4757C1DA.6060603@cn.fujitsu.com>
On Thursday 06 December 2007 20:33, Li Zefan wrote:
> The casting is safe only when the list_head member is the
> first member of the structure.
Even so, I don't think too safe :) It might technically work,
but it could break more easily.
So even if you find places where list_head is the first member of
a structure, it would be nice to explicitly use the list_head member
and avoid casts IMO.
Thanks,
Nick
> Signed-off-by: Li Zefan <lizf@cn•fujitsu.com>
>
> ---
> arch/ppc/syslib/ocp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/ppc/syslib/ocp.c b/arch/ppc/syslib/ocp.c
> index 3f5be2c..d42d408 100644
> --- a/arch/ppc/syslib/ocp.c
> +++ b/arch/ppc/syslib/ocp.c
> @@ -376,7 +376,7 @@ ocp_remove_one_device(unsigned int vendor, unsigned int
> function, int index)
>
> down_write(&ocp_devices_sem);
> dev = __ocp_find_device(vendor, function, index);
> - list_del((struct list_head *)dev);
> + list_del(&dev->link);
> up_write(&ocp_devices_sem);
>
> DBG(("ocp: ocp_remove_one_device(vendor: %x, function: %x, index: %d)...
> done.\n", vendor, function, index));
next prev parent reply other threads:[~2007-12-07 4:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 9:33 [PATCH 1/3] POWERPC: don't cast a pointer to pointer of list_head Li Zefan
2007-12-07 4:07 ` Nick Piggin [this message]
2007-12-07 5:05 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712071507.10161.nickpiggin@yahoo.com.au \
--to=nickpiggin@yahoo$(echo .)com.au \
--cc=akpm@linux-foundation$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=lizf@cn$(echo .)fujitsu.com \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox