From: Michael Buesch <mb@bu3sch•de>
To: Wolfgang Denk <wd@denx•de>
Cc: Andrew Morton <akpm@osdl•org>,
paulus@au•ibm.com, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2] powerpc: Do not fail build if mkimage is not available
Date: Thu, 27 Dec 2007 19:13:10 +0100 [thread overview]
Message-ID: <200712271913.10433.mb@bu3sch.de> (raw)
In-Reply-To: <20071227101404.2C05F2405E@gemini.denx.de>
On Thursday 27 December 2007 11:14:04 Wolfgang Denk wrote:
> In message <200712261708.51432.mb@bu3sch•de> you wrote:
> > On Wednesday 26 December 2007 17:03:43 Andreas Schwab wrote:
> > > Michael Buesch <mb@bu3sch•de> writes:
> > >
> > > > + set +e
> > > > mkimage -A ppc -O linux -T kernel -C gzip -a 00000000 -e 00000000 \
> > > > $uboot_version -d "$vmz" "$ofile"
> > > > + [ $? -eq 0 ] || exit 0
> > > > + set -e
> > >
> > > mkimage ... || exit 0
> >
> > Could you PLEASE increase your verbosity?
> > Why is mkimage || exit 0 any better than my test?
>
> Because it works, while your's doesn't.
>
> Make runs each command in a new shell. Your "set +e" is in vain, and
> so is your test of the return code.
>
> Um... doesn't make throw an error anyway when the execution of
> mkimage fails?
I'm not sure what you are talking about at all, sorry.
set +e simply disables the abortion of the shell script if
the mkimage command fails. The test after that checks whether it failed
and returns success in that event, so the calling makefile does
_not_ interrupt. It only gives you a mkimage not found message.
I did test this patch on my machine where there is no mkimage
and it correctly aborts the shell script and throws an error,
while it does not abort the makefile process. And that is what we want.
--
Greetings Michael.
prev parent reply other threads:[~2007-12-27 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-26 15:55 [PATCH v2] powerpc: Do not fail build if mkimage is not available Michael Buesch
2007-12-26 16:03 ` Andreas Schwab
2007-12-26 16:08 ` Michael Buesch
2007-12-26 16:19 ` Andreas Schwab
2007-12-27 10:14 ` Wolfgang Denk
2007-12-27 10:17 ` Andreas Schwab
2007-12-27 18:13 ` Michael Buesch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712271913.10433.mb@bu3sch.de \
--to=mb@bu3sch$(echo .)de \
--cc=akpm@osdl$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@au$(echo .)ibm.com \
--cc=wd@denx$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox