Subject: Re: [PATCH v2] ucc_uart: add support for Freescale QUICCEngine UART

From: Scott Wood <[email-masked]>
Date: Wed, 2 Jan 2008 12:12:26 -0600

On Sat, Dec 29, 2007 at 04:10:54PM -0600, Timur Tabi wrote:
> Anton Vorontsov wrote:
> 
> >> +		ucc@2400 {
> >> +			device_type = "serial";
> >> +			compatible = "ucc_uart";
> >> +			model = "UCC";
> > 
> > model isn't used, is it needed at all?
> 
> I have no idea, but all the other UCC nodes have it, so I'm going to 
> keep it.  Maybe one day we'll merge QE and CPM drivers, so this would be 
> useful.

No, it wouldn't -- that's what compatible is for.

> >> +static struct of_platform_driver ucc_uart_of_driver = {
> >> +	.owner  	= THIS_MODULE,
> >> +	.name   	= "ucc_uart",
> > 
> > Maybe better fsl,ucc_uart?

fsl,qe-uart is defined by Documentation/powerpc/booting-without-of.txt.

> The CPM serial driver uses "cpm_uart" and the QE ethernet driver uses 
> "ucc_geth", so ucc_uart matches the pattern.

cpm_uart is a legacy match -- the current binding specifies
fsl,cpm1-smc-uart, fsl,cpm2-scc-uart, etc.

-Scott