public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb•de>
To: Li Li <r64360@freescale•com>
Cc: Phillips Kim <Kim.Phillips@freescale•com>,
	linuxppc-dev@ozlabs•org, Li Tony <Tony.Li@freescale•com>,
	Wood Scott <scottwood@freescale•com>
Subject: Re: [PATCH] powerpc: Add MPC837x PCIE controller RC mode support
Date: Thu, 3 Jan 2008 11:14:02 +0100	[thread overview]
Message-ID: <200801031114.05981.arnd@arndb.de> (raw)
In-Reply-To: <1199349066.4437.5.camel@Guyver>

On Thursday 03 January 2008, Li Li wrote:
> 
> > It's easy enough to just panic() if you find more than one primary
> > bus, 
> > since the information from the device tree is static enough that one 
> > will know how to fix this after seeing the error.
> > 
> 
> It is just a case. what about if do not find primary pci host.
> The current code can prevent this potential error and make system
> robust.

After some more research, I noticed that the distinction between
primary and secondary host bridges will go away _anyway_, so
I guess we shouldn't worry about it too much.

On powerpc64, we already don't care, as the arch/powerpc/kernel/isa-bridge.c
code takes care of legacy I/O areas there, instead of the PCI code.
It's only needed on machines with legacy ISA devices (PC keyboard,
floppy, ...), and those can be converted to use the isa-bridge code
at some point.

	Arnd <><

  reply	other threads:[~2008-01-03 10:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 11:16 [PATCH] powerpc: Add MPC837x PCIE controller RC mode support Li Li
2008-01-02 11:53 ` Arnd Bergmann
2008-01-03  6:40   ` Li Li
2008-01-03  8:14     ` Arnd Bergmann
2008-01-03  8:31       ` Li Li
2008-01-03 10:14         ` Arnd Bergmann [this message]
2008-01-03 10:08           ` Li Li
2008-01-02 15:23 ` Kumar Gala
2008-01-03  5:56   ` Li Li
2008-01-02 15:51 ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801031114.05981.arnd@arndb.de \
    --to=arnd@arndb$(echo .)de \
    --cc=Kim.Phillips@freescale$(echo .)com \
    --cc=Tony.Li@freescale$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=r64360@freescale$(echo .)com \
    --cc=scottwood@freescale$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox