From: Olof Johansson <olof@lixom•net>
To: Josh Boyer <jwboyer@linux•vnet.ibm.com>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev@ozlabs•org
Subject: Re: Enable RTC for Ebony and Walnut
Date: Sun, 6 Jan 2008 14:48:23 -0600 [thread overview]
Message-ID: <20080106204823.GB12640@lixom.net> (raw)
In-Reply-To: <20080102114208.GD23168@localhost.localdomain>
On Wed, Jan 02, 2008 at 10:42:08PM +1100, David Gibson wrote:
> On Fri, Dec 21, 2007 at 03:29:22PM -0600, Olof Johansson wrote:
> > Hi,
> >
> > On Fri, Dec 21, 2007 at 01:21:30PM +1100, David Gibson wrote:
> > > Index: working-2.6/arch/powerpc/platforms/Kconfig
> > > ===================================================================
> > > --- working-2.6.orig/arch/powerpc/platforms/Kconfig 2007-12-10 10:52:44.000000000 +1100
> > > +++ working-2.6/arch/powerpc/platforms/Kconfig 2007-12-21 13:11:34.000000000 +1100
> > > @@ -315,6 +315,9 @@ config FSL_ULI1575
> > > config CPM
> > > bool
> > >
> > > +config OF_RTC
> > > + bool
> > > +
> >
> > New config options should have descriptions, even if they're silent
> > ones.
>
> Uh.. but if there's a description, won't kconfig prompt for the
> option? This one should only ever be selected by the platform
> options.
Sorry, should have said "should have help texts to describe them". Yes,
the one-line description will trigger a question, but adding a short
help text describing what the config option is for does not.
-Olof
next prev parent reply other threads:[~2008-01-06 20:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-21 2:21 Enable RTC for Ebony and Walnut David Gibson
2007-12-21 5:16 ` Stephen Rothwell
2007-12-21 21:29 ` Olof Johansson
2008-01-02 11:42 ` David Gibson
2008-01-06 20:48 ` Olof Johansson [this message]
2008-01-11 3:25 ` Enable RTC for Ebony and Walnut (v2) David Gibson
2008-01-11 6:29 ` Stephen Rothwell
2008-01-14 4:02 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080106204823.GB12640@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=jwboyer@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox